fix: sample on TraceOperation and root span metrics and tags #3944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3944 +/- ##
==========================================
- Coverage 97.85% 97.84% -0.02%
==========================================
Files 1303 1303
Lines 78139 78149 +10
Branches 3894 3895 +1
==========================================
- Hits 76462 76461 -1
- Misses 1677 1688 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
BenchmarksBenchmark execution time: 2024-09-25 17:57:07 Comparing candidate commit aefd6fa in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 23 metrics, 2 unstable metrics. |
ZStriker19
commented
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
By changing what the trace operation returns for its metadata by checking the root span as well for it, we can easily sample on all values both in the trace operation (which will be added to the root span before flush) and the root span.
Motivation:
Previously Ruby was not up to spec because only metadata attached to the trace operation was able to be sampled on. This meant that users could possibly see tag or metric values on the root span in the UI but not be able actually sample on them.
Additional Notes:
How to test the change?
Unsure? Have a question? Request a review!